[webkit-reviews] review granted: [Bug 73350] [chromium] Allow scrolling non-root layers in the compositor thread : [Attachment 137869] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 07:54:48 PDT 2012


James Robinson <jamesr at chromium.org> has granted Sami Kyostila
<skyostil at google.com>'s request for review:
Bug 73350: [chromium] Allow scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350

Attachment 137869: Patch
https://bugs.webkit.org/attachment.cgi?id=137869&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137869&action=review


OK, I think we're nearly there.

> Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h:67
> +    virtual void scrollBy(const IntSize&);

OVERRIDE

> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h:116
> +    virtual void didScroll(const IntSize&) { }

OVERRIDE

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:574
> +static LayerChromium* findLayerById(LayerChromium* layer, int id)

why is this structured differently from CCLayerImpl::findLayerById()? why isn't
it the same function just templatized?

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:681
> +    // Scroll event is ignored because the hit layer is not facing the
viewer.

shouldn't the hit test just skip the layer in this case? why would the backface
of a layer cause us to eat the scroll?


More information about the webkit-reviews mailing list