[webkit-reviews] review denied: [Bug 84246] [Qt] add LayoutTestController::setPrinting support to Qt unit tests : [Attachment 137894] patch that makes the Qt port properly handle setPrinting when creating pixel tests

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Milian Wolff
<milian.wolff at kdab.com>'s request for review:
Bug 84246: [Qt] add LayoutTestController::setPrinting support to Qt unit tests
https://bugs.webkit.org/show_bug.cgi?id=84246

Attachment 137894: patch that makes the Qt port properly handle setPrinting
when creating pixel tests
https://bugs.webkit.org/attachment.cgi?id=137894&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137894&action=review


Looks good in general, but I think the function should be moved. More detailed
comment below.

> Source/WebKit/qt/Api/qwebframe.h:229
> +    void paintPagesWithBoundaries(QImage &);

This function is only relevant for DRT, so I think it should be moved to
DumpRenderTreeSupport (I'm sure we can get the WebCore::Frame pointer there,
too :). Also I think it should return a QImage instead of taking a reference.