[webkit-reviews] review denied: [Bug 84325] [GTK] Build and run TestWebKitAPI unit tests : [Attachment 137866] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 84325: [GTK] Build and run TestWebKitAPI unit tests
https://bugs.webkit.org/show_bug.cgi?id=84325

Attachment 137866: Patch
https://bugs.webkit.org/attachment.cgi?id=137866&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137866&action=review


> Source/ThirdParty/gtest/GNUmakefile.am:65
> +# #included by gtest-all.cc.

Did you mean to have the second '#' here?

> Tools/Scripts/run-gtk-tests:47
> +    TEST_DIRS = [ "unittests", "WebKit2APITests", "TestWebKitAPI/WTF" ]

I'm pretty sure

> Tools/Scripts/run-gtk-tests:271
> +    def _run_test_google(self, test):
> +	   tester_command = [test]
> +	   skipped_tests_cases = self._test_cases_to_skip(test)
> +	   if skipped_tests_cases:
> +	       tester_command.append("--gtest_filter=-%s" %
":".join(skipped_tests_cases))
> +
> +	   return not self._create_process(tester_command,
env=self._test_env).wait()
> +
> +    def _run_test(self, test):
> +	   if "unittests" in test or "WebKit2APITests" in test:
> +	       return self._run_test_glib(test)
> +
> +	   if "TestWebKitAPI" in test:
> +	       return self._run_test_google(test)
> +
> +	   return False
> +

The logic for running the API tests is already in Tools/Scripts/run-api-tests,
so we get that script working instead probably.