[webkit-reviews] review denied: [Bug 84327] [Qt] Make DRT not to dump pixel results if test is layoutTestController.dumpAsText() was called : [Attachment 137875] don't dump pixels if shouldDumpAsText is true

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied	review:
Bug 84327: [Qt] Make DRT not to dump pixel results if test is
layoutTestController.dumpAsText() was called
https://bugs.webkit.org/show_bug.cgi?id=84327

Attachment 137875: don't dump pixels if shouldDumpAsText is true
https://bugs.webkit.org/attachment.cgi?id=137875&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137875&action=review


Only small nitpicks, otherwise LGTM. Please update the patch and upload it with
r?

> Tools/ChangeLog:5
> +	   Qt: don't dump pixels if test should be dumped as text
> +
> +	   [Qt] don't dump pixels if test should be dumped as text

Could you add the title (the new one, please) only once to the changelog?

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:951
>      // FIXME: All other ports don't dump pixels, if generatePixelResults is
false.

Please remove this FIXME, we don't need anymore after your fix.