[webkit-reviews] review granted: [Bug 84181] DevTools highlights elements in frames at un-scaled positions : [Attachment 137715] patch v2 (added comments in ChangeLog)

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 84181: DevTools highlights elements in frames at un-scaled positions
https://bugs.webkit.org/show_bug.cgi?id=84181

Attachment 137715: patch v2 (added comments in ChangeLog)
https://bugs.webkit.org/attachment.cgi?id=137715&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137715&action=review


> LayoutTests/inspector/elements/highlight-node-scaled.html:39
> +    window.internals.settings.setPageScaleFactor(2, 0, 0);

This should be:
if (window.internals)
    window.internals.settings.setPageScaleFactor(2, 0, 0);

So that the test could be loaded outside DRT.