[webkit-reviews] review canceled: [Bug 84315] InspectorValue's doubleQuoteString() takes a long time : [Attachment 137836] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has canceled Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 84315: InspectorValue's doubleQuoteString() takes a long time
https://bugs.webkit.org/show_bug.cgi?id=84315

Attachment 137836: Patch
https://bugs.webkit.org/attachment.cgi?id=137836&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137836&action=review


> Source/WebCore/inspector/InspectorValues.cpp:476
> +	       if (!escapeChar(c, dst)) {
> +		   if (c < 32 || c > 126 || c == '<' || c == '>') {

escapeChar() is unfortunately not optimized in any way which is the main issue.


We should try to replace it by a HashMap. That would be simpler and could be
fast enough.