[webkit-reviews] review granted: [Bug 83608] [chromium] Refactor opaque content transform out of Skia context : [Attachment 136962] Address nits

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 83608: [chromium] Refactor opaque content transform out of Skia context
https://bugs.webkit.org/show_bug.cgi?id=83608

Attachment 136962: Address nits
https://bugs.webkit.org/attachment.cgi?id=136962&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136962&action=review


Looks great.

> Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:49
> +void CanvasLayerTextureUpdater::paintContents(GraphicsContext& context,
PlatformContextSkia& platformContext, const IntRect& contentRect, float
contentsScale, IntRect* resultingOpaqueRect)

The parameter probably should be IntRect& if the implementation isn't going to
null check it - webkit seems to prefer a non-const reference for non-optional
out params (unlike chromium style)