[webkit-reviews] review granted: [Bug 84210] [chromium] Add tracing for active composited animations : [Attachment 137759] Fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 20:12:30 PDT 2012


James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 84210: [chromium] Add tracing for active composited animations
https://bugs.webkit.org/show_bug.cgi?id=84210

Attachment 137759: Fixes
https://bugs.webkit.org/attachment.cgi?id=137759&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137759&action=review


R=me

> Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.h:137
> +    // Animations live dual lives. When they are first created, they live on
the main thread and there isi

typo "isi" -> "is"

> Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.h:146
> +    // been transfered to the impl thread, the controlling instance is the
main
> +    // thread.

controlling instance is the main thread what? the main thread animation?


More information about the webkit-reviews mailing list