[webkit-reviews] review granted: [Bug 84302] JSC testing should have complete coverage over typed array types : [Attachment 137805] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 84302: JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302

Attachment 137805: the patch
https://bugs.webkit.org/attachment.cgi?id=137805&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=137805&action=review


r=me, with a comment below:

> LayoutTests/fast/js/script-tests/dfg-uint8array.js:109
> +	   shouldBe("safeGetter(a, b, c)", "" + safeGetter(checkA, b, c));

Would be nice to put in the actual values of b and c instead of the letters, so
it's clearer what went wrong if something goes wrong.

> LayoutTests/fast/js/script-tests/dfg-uint8array.js:136
> +	   shouldBe("getter(a, b, c)", "" + safeGetter(a, b));

Ditto.