[webkit-reviews] review denied: [Bug 84211] Call default constructor for CSSImageSetValue::ImageWithScale in CSSImageSetValue::bestImageScaleFactor(). : [Attachment 137712] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 84211: Call default constructor for CSSImageSetValue::ImageWithScale in
CSSImageSetValue::bestImageScaleFactor().
https://bugs.webkit.org/show_bug.cgi?id=84211

Attachment 137712: Patch
https://bugs.webkit.org/attachment.cgi?id=137712&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137712&action=review


> Source/WebCore/ChangeLog:13
> +	   * css/CSSImageSetValue.h:
> +	   (WebCore::CSSImageSetValue::ImageWithScale::ImageWithScale):

Outdated.

> Source/WebCore/css/CSSImageSetValue.cpp:80
> -    ImageWithScale image;
> +    ImageWithScale image = ImageWithScale();

This change is a no-op. image.scaleFactor will still contain uninitialized
data.