[webkit-reviews] review requested: [Bug 84088] [chromium] Simplify occlusion tracker API by passing layer iterator data : [Attachment 137779] Patch

[bugzilla-daemon at webkit.org]

Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 84088: [chromium] Simplify occlusion tracker API by passing layer iterator
data
https://bugs.webkit.org/show_bug.cgi?id=84088

Attachment 137779: Patch
https://bugs.webkit.org/attachment.cgi?id=137779&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
Another example:

	this->moveToLayerAsItself(parent, occlusion);
	EXPECT_TRUE(occlusion.occluded(parent, IntRect(30, 30, 70, 70)));

We want to check the occlsion of |parent|, but before |parent| is added to that
occlusion. We must 'enter' parent if it is in a different render surface than
the previous layer, or we violate the usage of the occlusion tracker as it
needs to know the current target. So we need to be able to visit the layer
without marking occlusion here.


Here's a CL with renaming enter/leave, and with Types::OcclusionTrackerType,
for your consideration.