[webkit-reviews] review denied: [Bug 84268] CSSValuePool: Make numeric value caches fixed-size arrays. : [Attachment 137749] Patch with less derp

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Andreas Kling <kling at webkit.org>'s
request for review:
Bug 84268: CSSValuePool: Make numeric value caches fixed-size arrays.
https://bugs.webkit.org/show_bug.cgi?id=84268

Attachment 137749: Patch with less derp
https://bugs.webkit.org/attachment.cgi?id=137749&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=137749&action=review


> Source/WebCore/css/CSSValuePool.h:73
> +    static const int maximumCacheableIntegerValue = 256;
> +
> +    RefPtr<CSSPrimitiveValue>
m_pixelValueCache[maximumCacheableIntegerValue];
> +    RefPtr<CSSPrimitiveValue>
m_percentValueCache[maximumCacheableIntegerValue];
> +    RefPtr<CSSPrimitiveValue>
m_numberValueCache[maximumCacheableIntegerValue];

Naming is off. Your maximumCacheableIntegerValue is not actually cacheable.