[webkit-reviews] review granted: [Bug 84197] [Chromium] Solid color layers should respect opacity value. : [Attachment 137627] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 11:26:30 PDT 2012


Adrienne Walker <enne at google.com> has granted David Reveman
<reveman at chromium.org>'s request for review:
Bug 84197: [Chromium] Solid color layers should respect opacity value.
https://bugs.webkit.org/show_bug.cgi?id=84197

Attachment 137627: Patch
https://bugs.webkit.org/attachment.cgi?id=137627&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=137627&action=review


Oops.  Thanks for fixing this.	R=me.

> Source/WebKit/chromium/tests/CCSolidColorLayerImplTest.cpp:104
> +    EXPECT_EQ(opacity,
quadCuller.quadList()[0]->toSolidColorDrawQuad()->opacity());

This test would have passed before, but I guess there's no reason not to add
it.


More information about the webkit-reviews mailing list