[webkit-reviews] review requested: [Bug 84181] DevTools highlights elements in frames at un-scaled positions : [Attachment 137715] patch v2 (added comments in ChangeLog)

[bugzilla-daemon at webkit.org]

Xianzhu Wang <wangxianzhu at chromium.org> has asked  for review:
Bug 84181: DevTools highlights elements in frames at un-scaled positions
https://bugs.webkit.org/show_bug.cgi?id=84181

Attachment 137715: patch v2 (added comments in ChangeLog)
https://bugs.webkit.org/attachment.cgi?id=137715&action=review

------- Additional Comments from Xianzhu Wang <wangxianzhu at chromium.org>
(In reply to comment #2)
> Please explain what changed and why in the ChangeLog. I can't reproduce it on
ToT Chromium. Also, I am not sure what you expect to "scale" in a given test
case.

Sorry for not being clear in the last patch. Added comments in ChangeLog in
this patch.

The scaling feature is used on some mobile platforms, e.g. chromium-android.
However, the issue can be reproduced on all platforms with the new test case
which forces scaling with window.internals.settings.setPageScale(2, 0, 0). The
change uses FrameView::contentsToRootView() to map the coordinates of a node in
a frame to the coordinates in the main view, instead of calculating by only the
offsets.