[webkit-reviews] review denied: [Bug 84048] ShadowRoot needs resetStyleInheritance : [Attachment 137623] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 84048: ShadowRoot needs resetStyleInheritance
https://bugs.webkit.org/show_bug.cgi?id=84048

Attachment 137623: Patch
https://bugs.webkit.org/attachment.cgi?id=137623&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=137623&action=review


> Source/WebCore/ChangeLog:7
> +	  
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-
root-attributes

Could you explain the change itself briefly?

> Source/WebCore/css/CSSStyleSelector.cpp:1638
> +void CSSStyleSelector::applyResetStyleInheritance(MatchResult& result)

This isn't the right approach.
- The flag should affect not only for direct children of the shadow boundary
- Allocating properties for each style resolution is too expensive.

I think this "reset" thing should be handled at where we compute the
inheritance in RenderStyle object
because RenderStyle is responsible for style inheritance in WebKit.
You can find such places by seeing the callers of RenderStyle::inheritFrom().