[webkit-reviews] review denied: [Bug 81970] Web Inspector: x-frame security errors logged when typing in the console are annoying. : [Attachment 137688] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 81970: Web Inspector: x-frame security errors logged when typing in the
console are annoying.
https://bugs.webkit.org/show_bug.cgi?id=81970

Attachment 137688: Patch
https://bugs.webkit.org/attachment.cgi?id=137688&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137688&action=review


> Source/WebCore/inspector/PageRuntimeAgent.cpp:72
> +    Frame* mainFrame = m_inspectedPage->mainFrame();

I would use a counter here.

> Source/WebCore/inspector/PageRuntimeAgent.cpp:74
> +    for (Frame* frame = mainFrame; frame; frame =
frame->tree()->traverseNext(mainFrame))

I would use a static counter on console instead.