[webkit-reviews] review granted: [Bug 84240] Web Inspector: DataGrid should use explicit root node : [Attachment 137686] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 07:54:04 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 84240: Web Inspector: DataGrid should use explicit root node
https://bugs.webkit.org/show_bug.cgi?id=84240

Attachment 137686: Patch
https://bugs.webkit.org/attachment.cgi?id=137686&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137686&action=review


> Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js:208
> +	   this._dataGrid = new WebInspector.DataGrid(columns, new
WebInspector.DataGridNode());

You should create root node implicitly within the data grid.


More information about the webkit-reviews mailing list