[webkit-reviews] review denied: [Bug 84232] Add PassThis=* to support the methods/callbacks which requires to pass "this" value. : [Attachment 137660] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 03:38:25 PDT 2012


Kentaro Hara <haraken at chromium.org> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 84232: Add PassThis=* to support the methods/callbacks which requires to
pass "this" value.
https://bugs.webkit.org/show_bug.cgi?id=84232

Attachment 137660: Patch
https://bugs.webkit.org/attachment.cgi?id=137660&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137660&action=review


r- due to missing CodeGenerator*.pm. Please include the change of
CodeGenerator*.pm.

> Source/WebCore/bindings/scripts/test/TestObj.idl:161
> +	   [PassThis=ThisClaas] void methodRequiresThisToPass(in ThisClass
param);

Shouldn't we move this test case to TestCallback.idl, since [PassThis] works
for callback interfaces?

Typo: This*Class*


More information about the webkit-reviews mailing list