[webkit-reviews] review canceled: [Bug 84004] DFG should have constant propagation : [Attachment 137652] the patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has canceled Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 84004: DFG should have constant propagation
https://bugs.webkit.org/show_bug.cgi?id=84004

Attachment 137652: the patch
https://bugs.webkit.org/attachment.cgi?id=137652&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
Fixed two hilarious bugs that this patch introduced:

- LogicalNot(foo) is not an integer.  Really, it isn't.  In fact, it's a
boolean.  Imagine that.

- Don't replace JSConstant or WeakJSConstant with JSConstant, because at best
that's a waste of CPU cycles and at worst, it's just plain wrong
(WeakJSConstant should not be coerced into a JSConstant).