[webkit-reviews] review granted: [Bug 60746] IndexedDB chooses wrong record on PREV_NO_DUPLICATE index cursor : [Attachment 137609] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 17 15:13:57 PDT 2012
Ojan Vafai <ojan at chromium.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 60746: IndexedDB chooses wrong record on PREV_NO_DUPLICATE index cursor
https://bugs.webkit.org/show_bug.cgi?id=60746
Attachment 137609: Patch
https://bugs.webkit.org/attachment.cgi?id=137609&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137609&action=review
> LayoutTests/storage/indexeddb/mozilla/index-prev-no-duplicate.html:10
> +<link rel="stylesheet" href="../../../fast/js/resources/js-test-style.css">
Nit: you don't need this. js-test-pre inserts the stylesheet for you.
> LayoutTests/storage/indexeddb/mozilla/index-prev-no-duplicate.html:19
> +<p id="description"></p>
> +<div id="console"></div>
Nit: you don't need these elements. js-test-pre will insert them for you.
> LayoutTests/storage/indexeddb/mozilla/index-prev-no-duplicate.html:118
> +function testPrev() {
Nit: here and blow the style is inconsistent with the above. Curly brace should
be on the next line.
More information about the webkit-reviews
mailing list