[webkit-reviews] review granted: [Bug 84189] nrwt: restart the driver in every new directory : [Attachment 137596] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 84189: nrwt: restart the driver in every new directory
https://bugs.webkit.org/show_bug.cgi?id=84189

Attachment 137596: Patch
https://bugs.webkit.org/attachment.cgi?id=137596&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137596&action=review


How do we evaluate whether this improves things? Just by looking subjectively
at the flakiness dashboard?

> Tools/Scripts/webkitpy/layout_tests/controllers/worker.py:147
> +	       if not self._options.batch_size and not
self._options.fully_parallel and not self._last_test_dir == test_dir:

not self._last_test_dir == test_dir --> self._last_test_dir != test_dir ?