[webkit-reviews] review granted: [Bug 84111] -webkit-mask-box-image does not draw when layer tree flattening is enabled : [Attachment 137451] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 17 14:28:02 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 84111: -webkit-mask-box-image does not draw when layer tree flattening is
enabled
https://bugs.webkit.org/show_bug.cgi?id=84111

Attachment 137451: Patch
https://bugs.webkit.org/attachment.cgi?id=137451&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=137451&action=review


> Source/WebCore/rendering/InlineFlowBox.cpp:1292
> +    bool flattenCompositingLayers = !renderer()->view()->frameView() ||
renderer()->view()->frameView()->paintBehavior() &
PaintBehaviorFlattenCompositingLayers;

I think it would be cleaner to pass this down via PaintInfo, but that would be
a larger change.


More information about the webkit-reviews mailing list