[webkit-reviews] review denied: [Bug 84177] Lion Production Test failing with error: "Failed to stop httpd: pid file still exists" : [Attachment 137586] Try to remove apache's pid file in the case it's stale

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 84177: Lion Production Test failing with error: "Failed to stop httpd: pid
file still exists"
https://bugs.webkit.org/show_bug.cgi?id=84177

Attachment 137586: Try to remove apache's pid file in the case it's stale
https://bugs.webkit.org/attachment.cgi?id=137586&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
See the comment right after this ... you can't assume apache has exited until
the pid file is removed. If you delete the pid file too early, you may attempt
to restart the server while the previous server is still running, and fail. You
should only delete the pid file is the pid is gone.

You should probably reuse the log in http_server.py, which checks for the
running process.