[webkit-reviews] review denied: [Bug 74135] [CSS Regions] Auto width is not working for Regions : [Attachment 136684] Patch to apply containing block available width for region, whenever width is not specified.

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Swapna <spottabathini at innominds.com>'s
request for review:
Bug 74135: [CSS Regions] Auto width is not working for Regions
https://bugs.webkit.org/show_bug.cgi?id=74135

Attachment 136684: Patch to apply containing block available width for region,
whenever width is not specified.
https://bugs.webkit.org/attachment.cgi?id=136684&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136684&action=review


> Source/WebCore/rendering/RenderReplaced.cpp:375
> +	   if (!hasIntrinsicWidth && !style()->regionThread().isEmpty())
> +	       return containingBlock()->availableLogicalWidth();

I'd rather you find a way to put this in RenderRegion instead. Eventually we
have to move RenderRegion to be a RenderBlock subclass rather than a
RenderReplaced subclass, so if we put stuff in RenderReplaced, we're just going
to be confusing things when we make that switchover.