[webkit-reviews] review granted: [Bug 30996] `localStorage.setItem` can overwrite `localStorage` methods : [Attachment 137546] patch and layout test

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Ben Murdoch <benm at google.com>'s
request for review:
Bug 30996: `localStorage.setItem` can overwrite `localStorage` methods
https://bugs.webkit.org/show_bug.cgi?id=30996

Attachment 137546: patch and layout test
https://bugs.webkit.org/attachment.cgi?id=137546&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137546&action=review


> Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp:77
> +    if
(!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())

Nit: .IsEmpty() is not necessary.