[webkit-reviews] review granted: [Bug 83030] [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks() : [Attachment 137484] Proposed patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 83030: [EFL] DRT should support LayoutTestController's
dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=83030

Attachment 137484: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=137484&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137484&action=review


it is good to go,with some minor nits.

please reupload with them fixed, and "Reviewed by Antonio Gomes" in the
changelogs and only set cq?

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:242
>  Eina_Bool DumpRenderTreeChrome::processWork(void* data)

I think you can omit 'data' or use param_unused

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:259
> +	   ecore_idler_add(processWork, 0);

ecore_idler_add(processWork, 0 /*frame*/) maybe would be clearer