[webkit-reviews] review requested: [Bug 81084] Fix rendering of replaced elements with relative dimensions within a table cell. : [Attachment 137514] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 17 04:48:24 PDT 2012


arpitabahuguna at gmail.com has asked  for review:
Bug 81084: Fix rendering of replaced elements with relative dimensions within a
table cell.
https://bugs.webkit.org/show_bug.cgi?id=81084

Attachment 137514: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=137514&action=review

------- Additional Comments from arpitabahuguna at gmail.com
Julien, have made the changes as suggested by you. Thanks for the review.

Have added the expected files for the newly added test cases for the qt port.
The image height gives different values on qt as compared against windows (a
difference of 5px); hence have made the expected files port specific.

Also, have added the helper function hasRelativeWidthOrHeight() which checks
whether the style contains auto/percent dimensions. As this function is not
specific to RenderReplaced; have moved it outside the class.


More information about the webkit-reviews mailing list