[webkit-reviews] review requested: [Bug 83233] Add CodeGenerator support for sequence<> in callbacks : [Attachment 137503] Patch

[bugzilla-daemon at webkit.org]

Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked  for review:
Bug 83233: Add CodeGenerator support for sequence<> in callbacks
https://bugs.webkit.org/show_bug.cgi?id=83233

Attachment 137503: Patch
https://bugs.webkit.org/attachment.cgi?id=137503&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
Thanks arv, I have updated patch with above comments.

>  Also, if there are more than 2 parameters we will invoke the callback
multiple times.
Done. Avoiding multiple invocation of callback.

> [PassThis=WebKitMutationObserver] boolean handleEvent(in
sequence<MutationRecord> mutations, in WebKitMutationObserver observer);
Done. Now "this" value which needs to pass depends on PassThis="*" type
irrespective of the position of arguments.
Added test to TestCallback.idl verifies this behaviour.