[webkit-reviews] review denied: [Bug 78358] REGRESSION (Safari 5.0.5 - 5.1): Link is not colored as visited if default port number is present : [Attachment 137473] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied webkitlearner at gmail.com's request for
review:
Bug 78358: REGRESSION (Safari 5.0.5 - 5.1): Link is not colored as visited if
default port number is present
https://bugs.webkit.org/show_bug.cgi?id=78358

Attachment 137473: Patch
https://bugs.webkit.org/attachment.cgi?id=137473&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137473&action=review


> Source/WebCore/html/HTMLAnchorElement.h:152
> +	   KURL vistedURL =
document()->completeURL(fastGetAttribute(HTMLNames::hrefAttr).string());
> +	   m_cachedVisitedLinkHash =
WebCore::visitedLinkHash(document()->baseURL(),
AtomicString(vistedURL.string().utf8().data()));

All these conversions make no sense. :)  You're converting from an
AtomicString, to a STring, to a KURL, then to a STring, CSTring, and char* only
to go back to an AtomicSTring! :p