[webkit-reviews] review granted: [Bug 84098] Convert ShadowData and DropShadowFilterOperation to use IntPoint : [Attachment 137443] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 84098: Convert ShadowData and DropShadowFilterOperation to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=84098

Attachment 137443: Patch
https://bugs.webkit.org/attachment.cgi?id=137443&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137443&action=review


OK.

> Source/WebCore/platform/graphics/filters/FilterOperation.h:380
> +    IntPoint m_location; // FIXME: x and y should location be in Lengths?

Not english?

> Source/WebCore/rendering/style/ShadowData.cpp:87
> +    int shadowLeft = 0;
> +    int shadowRight = 0;
> +    int shadowTop = 0;
> +    int shadowBottom = 0;

We really need some sort of Quad for these sets. This comes up often.