[webkit-reviews] review granted: [Bug 84122] [Chromium] Clean up texture ids on the impl side when losing the context : [Attachment 137466] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Antoine Labour
<piman at chromium.org>'s request for review:
Bug 84122: [Chromium] Clean up texture ids on the impl side when losing the
context
https://bugs.webkit.org/show_bug.cgi?id=84122

Attachment 137466: Patch
https://bugs.webkit.org/attachment.cgi?id=137466&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137466&action=review


Looks like the correct code but needs tests to prevent regressions

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

this won't fly (will fail an SVN presubmit check). Seems like it shouldn't be
too hard to construct a unit test for this - just magick up a
CCLayerTreeHostImpl, stick an instance of each CCLayerImpl type touched here
into the tree, synthesize a lost context, then recreate with a mock context
that explodes if you try to bind a non-zero texture and do a draw pass