[webkit-reviews] review denied: [Bug 84048] ShadowRoot needs resetStyleInheritance : [Attachment 137421] Patch

Mon Apr 16 19:37:52 PDT 2012

Hajime Morrita <morrita at google.com> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 84048: ShadowRoot needs resetStyleInheritance
https://bugs.webkit.org/show_bug.cgi?id=84048

Attachment 137421: Patch
https://bugs.webkit.org/attachment.cgi?id=137421&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=137421&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:3081
>  void CSSStyleSelector::applyProperty(CSSPropertyID id, CSSValue *value)

This applyProperty() is an ultra host function and computing stuff here won't
be a good idea in general.
I guess we could precompute staff in CSSStyleSelector::initElement() or some
per-element call path.

> Source/WebCore/css/CSSStyleSelector.cpp:3083
> +    TreeScope* treeScope = m_element? m_element->treeScope() : 0;

Can treeScope be null?

> Source/WebCore/css/CSSStyleSelector.cpp:3088
> +	   || ((!m_parentNode || (treeScope &&
treeScope->resetStyleInheritance() && treeScope != m_parentNode->treeScope()))
&& value->isInheritedValue());

This condition looks complicated enough. Could we simplify this somehow?

> LayoutTests/fast/dom/shadow/shadow-root-resetStyleInheritance.html:1
> + <!DOCTYPE html>

Could you use ref test if possible?