[webkit-reviews] review denied: [Bug 78472] ShadowRoot needs applyAuthorStyles : [Attachment 137040] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 16 19:19:21 PDT 2012


Hajime Morrita <morrita at google.com> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 78472: ShadowRoot needs applyAuthorStyles
https://bugs.webkit.org/show_bug.cgi?id=78472

Attachment 137040: Patch
https://bugs.webkit.org/attachment.cgi?id=137040&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=137040&action=review


> LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles.html:1
> +<!DOCTYPE html>

I guess we can use reftest and which will be much simpler.
http://trac.webkit.org/wiki/Writing%20Reftests

> LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles.html:17
> +    -webkit-appearance: none;

Could you use some more trivial element like div and better-known styles?
Soem port haven't enabled <progress> element.


More information about the webkit-reviews mailing list