[webkit-reviews] review denied: [Bug 83664] [Refactoring] Move initial style setting for ProgressValueElement from attach method to createShadowSubtree method in HTMLProgressElement. : [Attachment 136812] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 16 19:12:52 PDT 2012
Hajime Morrita <morrita at google.com> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 83664: [Refactoring] Move initial style setting for ProgressValueElement
from attach method to createShadowSubtree method in HTMLProgressElement.
https://bugs.webkit.org/show_bug.cgi?id=83664
Attachment 136812: Patch
https://bugs.webkit.org/attachment.cgi?id=136812&action=review
------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136812&action=review
> Source/WebCore/html/HTMLProgressElement.cpp:91
> }
I'm sorry for the slow response.
Could you call updateFromElement() at HTMLProgressElement::createRenderer() or
some existing place?
Then we can eliminate attach() at all.
More information about the webkit-reviews
mailing list