[webkit-reviews] review granted: [Bug 84063] Make borderBoxRect sub-pixel precise and add a pixel snapped version : [Attachment 137389] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 84063: Make borderBoxRect sub-pixel precise and add a pixel snapped version
https://bugs.webkit.org/show_bug.cgi?id=84063

Attachment 137389: Patch
https://bugs.webkit.org/attachment.cgi?id=137389&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137389&action=review


> Source/WebCore/ChangeLog:10
> +	   at (0,0), and therefor won't snap to the same size as the element
it's covering.

you mean "therefore"

> Source/WebCore/rendering/RenderBox.h:458
> +    bool hasVisualOverflow() const { return m_overflow &&
!borderBoxRect().contains(m_overflow->visualOverflowRect()); }

Do we know what the concequences of having sub-pixel overflow detection here
is?  Can we test this?