[webkit-reviews] review denied: [Bug 80054] [chromium] Expose compositor filters to Aura through WebLayer : [Attachment 137172] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 80054: [chromium] Expose compositor filters to Aura through WebLayer
https://bugs.webkit.org/show_bug.cgi?id=80054

Attachment 137172: Patch
https://bugs.webkit.org/attachment.cgi?id=137172&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137172&action=review


> Source/Platform/chromium/public/WebFilterOperations.h:38
> +// A simple set of filter operations. This implementation does not currently

> +// support defining an order for the operations.

This seems unnecessarily restrictive.  I think having WebFilterOperations be a
list of WebFilterOperation instances would make a lot more sense and be more
powerful.  Then a caller would only have to construct the WebFilterOperation
instances that make sense for their use and add them to a WebFilterOperations
set to pass to the layer.  You would only have to define the WebFilterOperation
types that you need and WebFilterOperations could still convert easily to a
WebCore::FilterOperations.

> Source/Platform/chromium/public/WebLayer.h:102
> +    // Background filters are only possible on layers that are drawn
directly

nit: newline between function and comments for the next function