[webkit-reviews] review granted: [Bug 78095] [GStreamer] HRTFDatabaseLoader conflicts with AudioFileReader : [Attachment 136460] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 78095: [GStreamer] HRTFDatabaseLoader conflicts with AudioFileReader
https://bugs.webkit.org/show_bug.cgi?id=78095

Attachment 136460: Patch
https://bugs.webkit.org/attachment.cgi?id=136460&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136460&action=review


Looks good, but take a look at my comment below before landing.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:179
> +bool doGstInit()

Is this used outside the file now? It's no longer static. Now that you have
initializeGStreamer, perhaps it makese sense to rename this method to
differeniate it from initializeGStreamer. How about
initializeGStreamerAndRegisterWebKitWebSrc?