[webkit-reviews] review denied: [Bug 83797] [EFL] [DRT] Feeding key events with invalid keyName : [Attachment 136942] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Sudarsana Nagineni
<naginenis at gmail.com>'s request for review:
Bug 83797: [EFL] [DRT] Feeding key events with invalid keyName
https://bugs.webkit.org/show_bug.cgi?id=83797

Attachment 136942: Patch
https://bugs.webkit.org/attachment.cgi?id=136942&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136942&action=review


> Tools/DumpRenderTree/efl/EventSender.cpp:437
>      const CString cCharacter = character.get()->ustring().utf8();
>      const char* keyName = (location == DomKeyLocationNumpad) ?
keyPadNameFromJSValue(character.get()) : keyNameFromJSValue(character.get());
> -    if (!keyName)
> -	   keyName = cCharacter.data();
>  
> -    return new KeyEventInfo(keyName, modifiers);
> +    return new KeyEventInfo(keyName ? CString(keyName) : cCharacter,
modifiers);

Seems like keyPadNameFromJSValue() should return a CString now. That would
simplify this code block, I think.