[webkit-reviews] review requested: [Bug 83879] [GTK][WK2] Implement API for Geolocation permission requests in the GTK port : [Attachment 137310] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 16 03:48:40 PDT 2012


Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 83879: [GTK][WK2] Implement API for Geolocation permission requests in the
GTK port
https://bugs.webkit.org/show_bug.cgi?id=83879

Attachment 137310: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=137310&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching a new patch addressing the issues pointed out by Carlos, with the
exception of unit tests, that will be added later.

(In reply to comment #10)
> (From update of attachment 137082 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=137082&action=review
> 
> Please, merge both patches or file separate bug reports.

Filed a new bug for the part of adding a generic API for permission requests:
bug 84018


More information about the webkit-reviews mailing list