[webkit-reviews] review requested: [Bug 83004] [Plugins] delete ws_info regardless window mode : [Attachment 137267] [UNIX Plugins] delete ws_info, remove memory leak

[bugzilla-daemon at webkit.org]

Kwangmin Bang <justine.bang at samsung.com> has asked  for review:
Bug 83004: [Plugins] delete ws_info regardless window mode
https://bugs.webkit.org/show_bug.cgi?id=83004

Attachment 137267: [UNIX Plugins] delete ws_info, remove memory leak
https://bugs.webkit.org/attachment.cgi?id=137267&action=review

------- Additional Comments from Kwangmin Bang <justine.bang at samsung.com>
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1863a58..2b59ef9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2012-04-15  Bang Kwang min  <justine.bang at samsung.com>
>+
>+	  [Plugins] delete ws_info regardless of window mode.
>+	  https://bugs.webkit.org/show_bug.cgi?id=83004
>+
>+	  Reviewed by NOBODY (OOPS!).
>+
>+	  m_npWindow.ws_info should be deleted even if plugin run as windowless
mode to remove memory leak.
>+	  Every plugin works well after this patch without any crash.
>+	  Additionally, change casting syntax to C++ style.
>+
>+	  * plugins/PluginView.cpp:
>+	  (WebCore::PluginView::stop):
>+
> 2012-04-15  James Robinson  <jamesr at chromium.org>
> 
>	  [chromium] LayerRendererChromium shouldn't know anything about
CCLayerImpl
>diff --git a/Source/WebCore/plugins/PluginView.cpp
b/Source/WebCore/plugins/PluginView.cpp
>index 749f609..389a8fe 100644
>--- a/Source/WebCore/plugins/PluginView.cpp
>+++ b/Source/WebCore/plugins/PluginView.cpp
>@@ -366,8 +366,8 @@ void PluginView::stop()
>     }
> 
> #ifdef XP_UNIX
>-    if (m_isWindowed && m_npWindow.ws_info)
>-	     delete (NPSetWindowCallbackStruct *)m_npWindow.ws_info;
>+    if (m_npWindow.ws_info)
>+	     delete static_cast<NPSetWindowCallbackStruct
*>(m_npWindow.ws_info);
>     m_npWindow.ws_info = 0;
> #endif
>