[webkit-reviews] review granted: [Bug 80400] [Qt] Set WebCore imagedecoders as default, add fallback to QImageDecoder : [Attachment 136448] proposed patch with proper changelog

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 80400: [Qt] Set WebCore imagedecoders as default, add fallback to
QImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=80400

Attachment 136448: proposed patch with proper changelog
https://bugs.webkit.org/attachment.cgi?id=136448&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136448&action=review


r=me. There's a style nitpick to fix before landing and the diff in bugzilla
also shows "new mode 100755" for
Source/WebCore/platform/graphics/qt/ImageDecoderQt.h, which would an incorrect
mode for the file (should remain 100644).

>> Source/WebCore/platform/graphics/qt/ImageDecoderQt.cpp:192
>> +	QImage image(reinterpret_cast<uchar*>(buffer->getAddr(0,0)),
imageSize.width(), imageSize.height(), sizeof(ImageFrame::PixelData) *
imageSize.width(), m_reader->imageFormat());
> 
> Missing space after ,  [whitespace/comma] [3]

The style bot is right here :)