[webkit-reviews] review denied: [Bug 83004] [Plugins] delete ws_info regardless window mode : [Attachment 137267] [UNIX Plugins] delete ws_info, remove memory leak

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 16 01:07:37 PDT 2012


Simon Hausmann <hausmann at webkit.org> has denied Kwangmin Bang
<justine.bang at samsung.com>'s request for review:
Bug 83004: [Plugins] delete ws_info regardless window mode
https://bugs.webkit.org/show_bug.cgi?id=83004

Attachment 137267: [UNIX Plugins] delete ws_info, remove memory leak
https://bugs.webkit.org/attachment.cgi?id=137267&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137267&action=review


Looks good in general, but I think you can remove the if() altogether and there
are a few language nitpicks :)

> Source/WebCore/ChangeLog:3
> +	   [Plugins] delete ws_info regardless window mode.

"regardless window mode" -> "regardless of the window mode"

> Source/WebCore/ChangeLog:10
> +	   Additionally, change casting synta to C++ style.

synta -> syntax

> Source/WebCore/plugins/PluginView.cpp:370
> +    if (m_npWindow.ws_info)
> +	      delete static_cast<NPSetWindowCallbackStruct
*>(m_npWindow.ws_info);

I don't think the if() is needed at all. delete 0 is perfectly valid C++.


More information about the webkit-reviews mailing list