[webkit-reviews] review canceled: [Bug 80009] Setting '0.6' to the value of a range input makes the value 0.6000000000000001 : [Attachment 137264] Patch 2 - for Preliminary Review

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has canceled yosin at chromium.org's request for
review:
Bug 80009: Setting '0.6' to the value of a range input makes the value
0.6000000000000001
https://bugs.webkit.org/show_bug.cgi?id=80009

Attachment 137264: Patch 2 - for Preliminary Review
https://bugs.webkit.org/attachment.cgi?id=137264&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137264&action=review


Please do not set r? for an incomplete patch.
I hesitate to review this patch until the patch actually resolves the
type=number/range issues.


> Source/WebCore/platform/Decimal128Impl.cpp:42
> +namespace {

We don't use anonymous namespace.

> Source/WebCore/platform/Decimal128Impl.cpp:164
> +class BcdNum {

This should be BCDNumber or something.
http://www.webkit.org/coding/coding-style.html#names-basic
http://www.webkit.org/coding/coding-style.html#names-full-words