[webkit-reviews] review denied: [Bug 83999] Make NullPtr.h compile with clang -std=c++11 and libstdc++4.2 : [Attachment 137248] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Nico Weber <thakis at chromium.org>'s
request for review:
Bug 83999: Make NullPtr.h compile with clang -std=c++11 and libstdc++4.2
https://bugs.webkit.org/show_bug.cgi?id=83999

Attachment 137248: Patch
https://bugs.webkit.org/attachment.cgi?id=137248&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137248&action=review


> Source/WTF/wtf/NullPtr.h:48
> +// libstdc++ supports nullptr_t starting with gcc 4.6.
> +#if defined(__GLIBCXX__) && __GLIBCXX__ < 20110325
> +#define HAS_NULLPTR_T 0
>  #else
> +#define HAS_NULLPTR_T 1
> +#endif
>  
> +#if !HAS_NULLPTR_T
> +// Compiler supports nullptr, but standard library doesn't have nullptr_t.

I don't think this extra HAS_NULLPTR_T macro is helpful.  I think the typedef
can just go in the correct macro branch.  Also, is there a case where this
might be hit, but the compiler doesn't support decltype?