[webkit-reviews] review granted: [Bug 40547] Avoid using backing store for compositing layers that just need to clip : [Attachment 137188] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 15 14:49:40 PDT 2012


Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 40547: Avoid using backing store for compositing layers that just need to
clip
https://bugs.webkit.org/show_bug.cgi?id=40547

Attachment 137188: Patch
https://bugs.webkit.org/attachment.cgi?id=137188&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=137188&action=review


r+ assuming test failures are misleading or updated.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1363
> +	   || renderer->isTransparent() || renderer->hasMask() ||
renderer->hasReflection() || renderer->hasFilter()

I'd prefer these on separate lines just because every other test is, but I
don't really care.


More information about the webkit-reviews mailing list