[webkit-reviews] review granted: [Bug 83990] Day of week labels are wrong if WebCore::firstDayOfWeek() is not 0 : [Attachment 137226] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 83990: Day of week labels are wrong if WebCore::firstDayOfWeek() is not 0
https://bugs.webkit.org/show_bug.cgi?id=83990

Attachment 137226: Patch
https://bugs.webkit.org/attachment.cgi?id=137226&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137226&action=review


> Source/WebCore/ChangeLog:8
> +	   We passed the "weekStartDay" proerty value as a

Nit: *property*

> Source/WebCore/html/shadow/CalendarPickerElement.cpp:163
> +static void addProperty(const char* name, unsigned value, DocumentWriter&
writer)

I've not yet confirmed the spec, but should this be unsigned or int? What
should happen if we pass a negative value for weekStartDay?