[webkit-reviews] review granted: [Bug 72987] CSS 2.1 failure: first-letter-nested-004.htm fails : [Attachment 136967] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 13 14:24:29 PDT 2012

Eric Seidel <eric at webkit.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 72987: CSS 2.1 failure: first-letter-nested-004.htm fails

Attachment 136967: Patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136967&action=review

This looks good as far as I can tell.

> Source/WebCore/rendering/RenderBlock.cpp:5967
> +    if (child->isText()) {

Is this function hot?  Do we need to worry about ordering the cases such that
it's most likely to return early?

> Source/WebCore/rendering/RenderBlock.cpp:5997
> +	   // We found a lower-level node with first-letter, which supersedes
the higher-level style

Should end with a period.

More information about the webkit-reviews mailing list