[webkit-reviews] review requested: [Bug 79611] Be more restrictive when adding ScrollableArea's to FrameView's ScrollableArea's map : [Attachment 137094] patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 13 09:31:42 PDT 2012


Antonio Gomes <tonikitoo at webkit.org> has asked	for review:
Bug 79611: Be more restrictive when adding ScrollableArea's to FrameView's
ScrollableArea's map
https://bugs.webkit.org/show_bug.cgi?id=79611

Attachment 137094: patch v4
https://bugs.webkit.org/attachment.cgi?id=137094&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
Changes from v3.1:

-Fixed chromium reported issues with layout tests.
-added a test to check that dynamic changes to the overflow proper properly
updates the set.
-added change in FrameView::updateScrollableAreaSet to remove itself from its
parent when it fails to the following condition:
  if (!owner || !owner->renderer() ||
!owner->renderer()->visibleToHitTesting())
previously it was just bailing our earlier.


More information about the webkit-reviews mailing list