[webkit-reviews] review denied: [Bug 83883] Web Inspector: exception in heap profiler when expanding a class in summary view : [Attachment 137075] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 13 06:30:08 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 83883: Web Inspector: exception in heap profiler when expanding a class in
summary view
https://bugs.webkit.org/show_bug.cgi?id=83883

Attachment 137075: Patch
https://bugs.webkit.org/attachment.cgi?id=137075&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137075&action=review


> Source/WebCore/inspector/front-end/DOMUtils.js:36
> +Node.prototype.rangeOfWord = function(offset, stopCharacters,
stayWithinNode, direction)

I would call this file DOMExtension.js and would move highlight-related methods
into the WebInspector.UIUtils, into the WebInspector namespace.


More information about the webkit-reviews mailing list