[webkit-reviews] review canceled: [Bug 83777] Introduce MenuItemID to autofill popup : [Attachment 137054] Added argument with default value so we don't break the build

[bugzilla-daemon at webkit.org]

Keishi Hattori <keishi at webkit.org> has canceled Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 83777: Introduce MenuItemID to autofill popup
https://bugs.webkit.org/show_bug.cgi?id=83777

Attachment 137054: Added argument with default value so we don't break the
build
https://bugs.webkit.org/attachment.cgi?id=137054&action=review

------- Additional Comments from Keishi Hattori <keishi at webkit.org>
> (From update of attachment 136895 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=136895&action=review
> 
> > Source/WebKit/chromium/public/WebAutofillClient.h:43
> > +	 enum {
> 
> nit: we usually name enums, and then we use the enum name
> as the typename elsewhere.
> 
> shouldn't didAcceptAutofillSuggestion use a named enum type
> for the itemID parameter?
> 
> please also see:
> http://trac.webkit.org/wiki/ChromiumWebKitAPI#Enums

Positive itemID are unique ids used to identify the autofill item. And the enum
values are used for zero and negative itemIDs.

@fishd should I still use the enum name?

> > Source/WebKit/chromium/public/WebView.h:364
> > +	     const WebVector<int>& itemIDs) = 0;
> 
> Chrome doesn't yet call this function?  It is easy to land without breaking
Chrome?

I added a default value to the argument I want to remove, so we can transition
without breaking the build.